Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] Move dummy models and costs to testing #1544

Open
TNick opened this issue Jun 25, 2015 · 1 comment
Open

[enhancement] Move dummy models and costs to testing #1544

TNick opened this issue Jun 25, 2015 · 1 comment

Comments

@TNick
Copy link
Contributor

TNick commented Jun 25, 2015

I propose:

  • creating a new module in testing (model.py) with DummyModel, SoftmaxModel and TopoSoftmaxModel
  • moving SupervisedDummyCost and DummyCost to cost.py

Those are all located in test_sgd.py and can't be imported.

That's because I would like to avoid duplicating the code in pyl2extra.

Any objections?
@bouthilx
Copy link
Member

Looks like a good idea. I don't have any objection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TNick @bouthilx