Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PII redactions - use same algorithms as in feedback tool #42

Open
lisafast opened this issue Dec 19, 2024 · 1 comment
Open

PII redactions - use same algorithms as in feedback tool #42

lisafast opened this issue Dec 19, 2024 · 1 comment

Comments

@lisafast
Copy link
Owner

@HamzaAburaneh recommends we implement PII redaction algorithms from feedback tool to replace crappy regex currently in src/services/RedactionService.js - files it uses are in services/redactions.

I think Name redaction is still very imperfect? Hamza also said he plans to update the badwords list. I've been adding to manipulation.

Note that PII is currently redacted and replaced with XXX but still sent to AI.
Badwords and manipulation are redacted and replaced with ### and are NOT sent to the AI.

Link to algorithm:
https://github.com/alpha-canada-ca/feedback-viewer/blob/master/src/main/java/ca/gc/tbs/service/ContentService.java

Future issue when this is done - instead of sending redacted PII to the AI service, we should instead offer people the chance to change it - just like how feedback now works. Because if I look at the feedback questions with PII redactions, many become useless once PII is gone. Hamza knows all the details of this.

@lisafast
Copy link
Owner Author

@HamzaAburaneh I think you can close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant