Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automated withdrawal system #29

Open
BlinkyStitt opened this issue Feb 7, 2023 · 3 comments
Open

automated withdrawal system #29

BlinkyStitt opened this issue Feb 7, 2023 · 3 comments

Comments

@BlinkyStitt
Copy link
Contributor

#28 is more important. But we should work towards having automated withdrawals. We can dump thoughts about it here until we actually have time to code it.

One thing to remember is how this will interact with the referral system. we plan on referrals required at least $10 of credits.

  1. user deposits $10 for credits
  2. user creates a referral code
  3. either:
    a. don't allow them to withdraw their first $10
    b. withdrawing those first $10 disables referrals
@BlinkyStitt
Copy link
Contributor Author

if a user runs out of credits, their referral code should keep working. That way a referral using our RPC will give enough credits for this user to get out of the free tier.

@Bencyril
Copy link
Contributor

Bencyril commented Feb 7, 2023

For 3.If announced that withdrawing disables referrals then 3.b is way better, it doesn't let the user thinks he/she's locked
By disabling referral we avoid people abusing the system too

@yenicelik
Copy link
Contributor

I suppose these lines here allow withdrawal: https://github.com/llamanodes/payment-contracts/blob/main/contracts/Sweeper.vy#L40 so we can proceed with implementing the endpoint?

Also according to our last discussion, I suppose we want to proceed with only having a single input token for now? (the smart contract does not need to change I suppose)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants