Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom concat filter conflicts with Liquid's version #201

Open
dcoleman-lulzbot opened this issue Aug 19, 2021 · 0 comments
Open

Custom concat filter conflicts with Liquid's version #201

dcoleman-lulzbot opened this issue Aug 19, 2021 · 0 comments

Comments

@dcoleman-lulzbot
Copy link

Locomotive provides a custom filter called concat. At the time it was implemented, this was a unique name.

Since then, Liquid has added its own filter called concat, which provides a way to join arrays. However, this new function cannot be accessed due to the conflict with the Locomotive version.

Being able to use Liquid's concat would be very useful, as it provides a way to combine multiple arrays into a single array, as opposed to the Locomotive version which appends the arguments as strings. From what I can tell, The functionality of Locomotive's concat can be achieved with join and append.

Would you consider removing the custom concat or providing a workaround so the vanilla concat can be accessed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant