-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update development kit #587
Open
mjamilasfihani
wants to merge
29
commits into
lonnieezell:develop
Choose a base branch
from
mjamilasfihani:update-development-kit
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update development kit #587
mjamilasfihani
wants to merge
29
commits into
lonnieezell:develop
from
mjamilasfihani:update-development-kit
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use `uri_string()` to get the string from current url
I use `current_url()` and at line 51 I add an extra script in case if user use index.php :)
NOTE : Since url_is() is available start from CodeIgniter 4.0.5, user must update their application.
I remove the helper('auth) since it's no use in there (performance reason) and put the session check at the begin of code, because we need a session data right?
I add defaultLandingRoute to store the default route name after user success to login (depend on the real case) or fail in Permission & Role Filters too
sorry my mistake
…to lonnieezell-develop
Lonnieezell develop
The Routes.php now will use reserved routing from Auth.php
the Deptrac test failure because of the API rate limit, sometimes I repeat the test and somehow it work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the draft 😄
Feel free to do some check.
fix #586