Unable to apply patches on ament vendor packages

[KABILAN235]

Problem

Applying patches on ament vendor packages through patchAmentVendorGit seems to be problematic especially in cases where a minor patch required on one of the vendor packages requires a version bump.

Example

I'm using this package from the overlay that uses patchAmentVendorGit under the hood to fetch the source from here

gz-sensors-vendor = lib.patchGzAmentVendorGit rosSuper.gz-sensors-vendor {
    version = "8.2.0";
    hash = "sha256-wEUJoHbvvImuFbaKk84maw5AoKhoEhdU0uOYVBtHhI0=";
  };

Problem arises when we want to include a patch like this this have to be applied. Since patchAmentVendorGit doesn't support patches, the solution here would be to bump up the version from 8.2.0 -> 8.2.1 which isin't ideal

Proposed solution

Would be really cool if we can have a patches as an override attr which allows us to do something like this

gz-sensors-vendor = lib.patchGzAmentVendorGit rosSuper.gz-sensors-vendor {
    version = "8.2.0";
    hash = "sha256-wEUJoHbvvImuFbaKk84maw5AoKhoEhdU0uOYVBtHhI0=";
  }.overrideAttrs ({
    patches ? [], ...
  }: {
    patches = patches ++ [
      (self.fetchpatch {
        url = "https://github.com/gazebosim/gz-sensors/commit/aaef365e6c51dcf98334e9f7a70e5fc4e3281f91.patch";
        hash = "sha256-npFHdb0a3JBA8T6vke54DA08C93aNc/7c6xrfMBo7zI=";
        stripLen = 1;
      })
    ];
  });;

[wentasah]

I don't understand what is the problem. Could you write which exact errors you encounter?

Isn't it sufficient to put lib.patchGzAmentVendorGit expression in parentheses before overriding it? Like this:

gz-sensors-vendor = (lib.patchGzAmentVendorGit rosSuper.gz-sensors-vendor {
    version = "8.2.0";
    hash = "sha256-wEUJoHbvvImuFbaKk84maw5AoKhoEhdU0uOYVBtHhI0=";
  }).overrideAttrs ({
    patches ? [], ...
  }: {
    patches = patches ++ [
      (self.fetchpatch {
        url = "https://github.com/gazebosim/gz-sensors/commit/aaef365e6c51dcf98334e9f7a70e5fc4e3281f91.patch";
        hash = "sha256-npFHdb0a3JBA8T6vke54DA08C93aNc/7c6xrfMBo7zI=";
        stripLen = 1;
      })
    ];
  });;