Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming #347

Closed
wants to merge 2 commits into from
Closed

Fix naming #347

wants to merge 2 commits into from

Conversation

stefonarch
Copy link
Member

@stefonarch stefonarch commented Jun 18, 2023

Renamed Advanced Settings → General Settings and Basic Settings → Appearance Settings.
Fixes #346
Related #289

@tsujan
Copy link
Member

tsujan commented Jun 18, 2023

This kind of change can easily cause regressions, while its review isn't easy. Considering the fact that there is no issue in the app, I don't see why we should do this.

@stefonarch
Copy link
Member Author

stefonarch commented Jun 18, 2023

I'm aware of this, but working with the code as it is is quite confusing. I tested loading other translations, it looks working fine all.

@tsujan
Copy link
Member

tsujan commented Jun 18, 2023

... is quite confusing

You'll easily get used to it after a while. It's much simpler than the main code.

Moreover, the GUI's order might be changed again later, and we don't want to make heavy changes each time.

@stefonarch
Copy link
Member Author

Moreover, the GUI's order might be changed again later, and we don't want to make heavy changes each time.

I just think that the code filenames should respect what there are about. I don't think there will be much to reorder in future.

@stefonarch stefonarch closed this Jan 25, 2024
@shlyakpavel
Copy link
Member

shlyakpavel commented Oct 10, 2024

This kind of change can easily cause regressions, while its review isn't easy.

Apart from translations, what seems to be the problem? What kind of regressions do occur when changing class and file names?
The only thing that comes to my mind are signals and slots, but they are referenced without obsolete macros, so that should be fine as well

@tsujan
Copy link
Member

tsujan commented Oct 10, 2024

What kind of regressions do occur when changing class and file names?

Regressions could easily happen because we're fallible human beings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming in code is confusing
3 participants