Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add Qt6 support #436

Closed
DAP-DarkneSS opened this issue Aug 3, 2021 · 9 comments
Closed

Please add Qt6 support #436

DAP-DarkneSS opened this issue Aug 3, 2021 · 9 comments

Comments

@DAP-DarkneSS
Copy link

Expected Behavior
Current Behavior
Possible Solution
Steps to Reproduce (for bugs)
  1. cmake(Qt6LinguistTools) & cmake(Qt6Widgets)
  2. /usr/bin/cmake /home/abuild/rpmbuild/BUILD/qtermwidget-0.17.0/. '-GUnix Makefiles' -DCMAKE_INSTALL_PREFIX:PATH=/usr -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib64 -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DCMAKE_INSTALL_LIBDIR:PATH=lib64 -DCMAKE_INSTALL_LIBEXECDIR=/usr/libexec -DCMAKE_BUILD_TYPE=RelWithDebInfo '-DCMAKE_C_FLAGS=-O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DNDEBUG' '-DCMAKE_CXX_FLAGS=-O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DNDEBUG' '-DCMAKE_Fortran_FLAGS=-O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DNDEBUG' '-DCMAKE_EXE_LINKER_FLAGS=-flto=auto -Wl,--as-needed -Wl,--no-undefined -Wl,-z,now' '-DCMAKE_MODULE_LINKER_FLAGS=-flto=auto -Wl,--as-needed' '-DCMAKE_SHARED_LINKER_FLAGS=-flto=auto -Wl,--as-needed -Wl,--no-undefined -Wl,-z,now' -DLIB_SUFFIX=64 -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DBUILD_SHARED_LIBS:BOOL=ON -DBUILD_STATIC_LIBS:BOOL=OFF -DCMAKE_COLOR_MAKEFILE:BOOL=OFF -DCMAKE_INSTALL_DO_STRIP:BOOL=OFF -DCMAKE_MODULES_INSTALL_DIR=/usr/lib64/cmake/qtermwidget-qt5 -DCMAKE_BUILD_TYPE=RelWithDebInfo -DPULL_TRANSLATIONS=no -DUSE_UTF8PROC=yes
    [ 24s] -- The C compiler identification is GNU 11.1.1
    [ 24s] -- The CXX compiler identification is GNU 11.1.1
    [ 24s] -- Detecting C compiler ABI info
    [ 24s] -- Detecting C compiler ABI info - done
    [ 24s] -- Check for working C compiler: /usr/bin/cc - skipped
    [ 24s] -- Detecting C compile features
    [ 24s] -- Detecting C compile features - done
    [ 24s] -- Detecting CXX compiler ABI info
    [ 24s] -- Detecting CXX compiler ABI info - done
    [ 24s] -- Check for working CXX compiler: /usr/bin/c++ - skipped
    [ 24s] -- Detecting CXX compile features
    [ 24s] -- Detecting CXX compile features - done
    [ 24s] CMake Error at CMakeLists.txt:37 (find_package):
    [ 24s] By not providing "FindQt5Widgets.cmake" in CMAKE_MODULE_PATH this project
    [ 24s] has asked CMake to find a package configuration file provided by
    [ 24s] "Qt5Widgets", but CMake did not find one.
    [ 24s]
    [ 24s] Could not find a package configuration file provided by "Qt5Widgets"
    [ 24s] (requested version 5.12.0) with any of the following names:
    [ 24s]
    [ 24s] Qt5WidgetsConfig.cmake
    [ 24s] qt5widgets-config.cmake
    [ 24s]
    [ 24s] Add the installation prefix of "Qt5Widgets" to CMAKE_PREFIX_PATH or set
    [ 24s] "Qt5Widgets_DIR" to a directory containing one of the above files. If
    [ 24s] "Qt5Widgets" provides a separate development package or SDK, be sure it has
    [ 24s] been installed.
    [ 24s]
    [ 24s]
    [ 24s] -- Configuring incomplete, errors occurred!
Context
System Information
  • Distribution & Version: openSUSE Factory (rolling)
  • Kernel: 5.13.6
  • Qt Version: 6.2
  • lxqt-build-tools Version: 0.9.0
  • Package version: 0.17.0
@yan12125
Copy link
Member

yan12125 commented Aug 3, 2021

I have a work-in-progress branch at https://github.com/lxqt/qtermwidget/tree/wip-qt6. It is far from finished, though.

See also lxqt/lxqt#1901

@DAP-DarkneSS
Copy link
Author

https://github.com/lxqt/qtermwidget/tree/wip-qt6

Qt5LinguistTools is still required by cmake.
_log.txt

@yan12125
Copy link
Member

Yep, https://github.com/lxqt/lxqt-build-tools/blob/master/cmake/modules/LXQtTranslateTs.cmake.in is not updated for Qt 6 yet.

@yan12125
Copy link
Member

Here comes the first major issue - KPty is not compatible with Qt 6 yet https://phabricator.kde.org/T13940. Although theoretically we can move forward without waiting for KDE devs, nobody in LXQt understands kptyprocess well as far as I know.

@DAP-DarkneSS
Copy link
Author

It sounds OK for me to work with KDE.

@yan12125 yan12125 mentioned this issue Aug 31, 2021
@yan12125 yan12125 moved this to Todo in Qt 6 support Jul 24, 2023
@Conan-Kudo
Copy link

KPty is now ported to Qt6, and at least in Fedora 40, exists as a framework package kf6-kpty.

@yan12125
Copy link
Member

yan12125 commented Feb 22, 2024

Yes, we can now learn from KF6 kpty. There are WIP pull requests at #532 and lxqt/qterminal#1067.

EDIT: use the latest pull request for qtermwidget

@yan12125 yan12125 moved this from Todo to In Progress in Qt 6 support Mar 8, 2024
@ADebla
Copy link

ADebla commented Apr 5, 2024

Do you any updates about the PyQt6 full support ?

@yan12125
Copy link
Member

Qt6 and PyQt6 are now supported! Although there are still some minor glitches, qterminal and qtermwidget are usable with Qt 6 in general.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Qt 6 support Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants