Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include safety comments on unsafe blocks in chapter 3? #21

Open
helixbass opened this issue Mar 19, 2023 · 0 comments
Open

Include safety comments on unsafe blocks in chapter 3? #21

helixbass opened this issue Mar 19, 2023 · 0 comments

Comments

@helixbass
Copy link

Type of error

Minor technical mistake

Location of the error

https://marabos.nl/atomics/memory-ordering.html#fences

Description of the error

In the "Let’s take a look at a more complicated use case of release and acquire fences" example, there are no // safety: ... comments on the unsafe blocks

I was finding the safety comments on other unsafe blocks to be helpful and I know this is considered a best practice so seems worth pointing out their absence here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant