Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make .detect_irregular_wt work again #39

Open
jonathanbratt opened this issue Jun 23, 2021 · 2 comments
Open

make .detect_irregular_wt work again #39

jonathanbratt opened this issue Jun 23, 2021 · 2 comments

Comments

@jonathanbratt
Copy link
Collaborator

This function works by detecting the pattern "[[Category:English irregular" in the wikitext for a word.

This pattern is often not getting picked up because it's not in a recognized section. For example, "ridden" and "taken" are picking up the past participle template, but not finding the irregular flag which is at the bottom of the English section (technically in the "anagrams" section). This is causing them to be processed as "ride -ed" and "take -ed".

@jonathanbratt
Copy link
Collaborator Author

note that irregulars might not all be flagged this way, too. I also see this in some cases:

{{head|en|verb form|cat2=irregular past participles}}

@jonthegeek
Copy link
Member

We can't find a case where this still happens (these two words are purposefully broken into "ride" "-en" and "take" "-en" now). If we find an example we'll come back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants