Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional bundle grouping options #42

Open
3 tasks
aligent-lturner opened this issue Dec 12, 2018 · 1 comment
Open
3 tasks

Add additional bundle grouping options #42

aligent-lturner opened this issue Dec 12, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@aligent-lturner
Copy link
Contributor

This issue is a:

  • Bug
  • [ x] Feature suggestion
  • Documentation issue
  • Other (Please Specify)

Environment

Question Answer
Magento version 2.x

Description

Let me preface this by saying I'm not 100% sure on this, but this is my understanding of the situation:

Currently, any module used in more than one page gets added to the single "shared" bundle. However, this might end up with modules used only on the PDP and PLP (for example) being loaded on every page.
I'm sure it wouldn't be simple to implement, but it would be useful to be able to produce additional bundles, such as a "catalog" bundle for modules common to PDP and PLP, a "shipping" bundle for modules common to cart and checkout, etc.

Expected result:

"shared" bundle reduced in size, with additional bundles for common functionally. In theory, this would provide a more optimal set of modules for each page.

Possible solutions:

Either allow the user to link pages, or work from a pre-defined set of linked pages.

@DrewML DrewML added the enhancement New feature or request label Dec 12, 2018
@DrewML
Copy link
Contributor

DrewML commented Dec 12, 2018

Thanks for getting the discussion started @aligent-lturner! Going to drop in some comments from @Januszpl as well:

image

I'm a bit unsure of what the efficacy of something like this would be. In some situations, if done wrong, this could make things a bit worse. My guess is that it would be a benefit in the scenario that those "2-page modules" are on the larger side, but chunking off few kilobyte bundles for those "2-page modules" would likely have similar or slightly worse performance (due to extra round trip + weaker gzip compression).

Having said all that, it's impossible to know without trying it out and running some traces with some real stores.

Would someone be interested in manually-tweaking a config file and doing some profiling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants