Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments needed in Black Master #62

Open
vv-monsalve opened this issue Nov 10, 2020 · 8 comments
Open

Adjustments needed in Black Master #62

vv-monsalve opened this issue Nov 10, 2020 · 8 comments

Comments

@vv-monsalve
Copy link
Collaborator

Please, lighten the joins and counters in the black master to avoid darker spots in text and improve legibility.
Browser previews at the bottom.

Screen Shot 2020-11-10 at 15 59 35
Screen Shot 2020-11-10 at 15 56 57

Preview on Browsers

OS X High Sierra Safari 11
Desktop_OS_X_High_Sierra_safari_11 1_

Windows 10 Chrome 69
Desktop_Windows_10_chrome_69 0_

Windows 10 Firefox 62
Desktop_Windows_10_firefox_62 0_

@marcologous
Copy link
Owner

Hi @vv-monsalve , I am currently working on this. Interesting previews on the Black weight though as it seems like it is showing the master. I have a [bracket from 600] to show more of the corners but then they may not be enough.

@vv-monsalve
Copy link
Collaborator Author

Hi @marcologous, I just saw you haven't merged the PR. Please, merge it first and work on the pushed source file to avoid having conflicts between files or losing job done on any end.
Thanks

@vv-monsalve
Copy link
Collaborator Author

vv-monsalve commented Dec 7, 2020

Hi @marcologous giving bracket layers a detailed inspection:

• It works well for the base letters (in the produced font, in the background is the bracket layer shape)
Screen Shot 2020-12-07 at 16 42 51

• It is not working in composite glyphs
composites

• For it to work in composites you would need to also create the bracket layer on each of the composite letters and ensure they are named the same as the base letter, in this case, Black [600]

Screen Shot 2020-12-07 at 16 53 58

• Check the anchor position between the layer and the bracket layer to ensure having the expected results

Hanken_Anchors

This would be a list of the base glyphs that use bracket layers in Hanken

Hanken Roman

K Black [700]
R Black [700]
a Black [700]
a Thin [700]
b Black [600]
d Black [600]
dcaron Black [600]
dcroat Black [600]
e Black [700]
eacute Black [700]
g Black [700]
h Black [700]
m Black [700]
n Black [700]
r Black [700]
s Black [700]
u Black [700]
g.ss01 Black [600]
g.ss02 Black [700]
one Black [700]
two Black [700]
four Black [700]
period Thin [200]
colon Thin [200]
semicolon Thin [200]
ellipsis Thin [200]
periodcentered Thin [200]
twodotenleader Thin [200]

Hanken Italics

period Black [500]
period Thin [500]
colon Thin [500]
semicolon Thin [500]
ellipsis Thin [500]
exclam Thin [500]
exclamdown Thin [500]
question Thin [500]
twodotenleader Thin [500]
questiongreek Thin [500]

@vv-monsalve
Copy link
Collaborator Author

vv-monsalve commented Dec 7, 2020

Please use the above lists to check/adjust all the composites based on them.

@marcologous
Copy link
Owner

Thanks @vv-monsalve ! I did not know that brackets don't work on composites... Will add the layers to them.

@vv-monsalve
Copy link
Collaborator Author

np! There is a script from Mekkablue but it didn't work well as it created multiple bracket layers in the composites and altered the spacing (LSB and RSB).
Luckily Hanken uses only two masters and there are not too many cases, so it could be done manually :)

@vv-monsalve
Copy link
Collaborator Author

Black master is looking better now. If only the e aperture could be cleared to prevent it from looking closed at some sizes.

Screen Shot 2021-09-14 at 20 49 01

Screen Shot 2021-09-14 at 20 48 46

@marcologous
Copy link
Owner

Hey @vv-monsalve ! Yes you are right about the "e". I can open it up more will do that later this evening 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants