-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve bookmarklet functionality for GitHub notebook URLs #3400
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Haleshot is attempting to deploy a commit to the marimo Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One note to address — the bookmarklet also works with .ipynb
files. They get automatically converted to marimo notebooks before being opened in the playground.
Have included .ipynb's and mentioned it in the note too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the QoL improvement!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Haleshot actually one thing, marimo.app/URL actually works with non-github URLs too I believe. The URL just needs to end with .py
or ipynb
. If you could restore the original URL construction that would be great, thanks!
Updated it accordingly (to the best of my knowledge). Hope it's fine now. |
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.13-dev2 |
📝 Summary
Fix incorrect bookmark hyperlink redirecting to 404 page.
🔍 Description of Changes
Create a popup dialog box instructing to open the bookmark/use it to open a marimo notebook on GitHub
📋 Checklist
📜 Reviewers
@akshayka OR @mscolnick