Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve bookmarklet functionality for GitHub notebook URLs #3400

Merged
merged 4 commits into from
Jan 11, 2025

Conversation

Haleshot
Copy link
Contributor

📝 Summary

Fix incorrect bookmark hyperlink redirecting to 404 page.
image

🔍 Description of Changes

Create a popup dialog box instructing to open the bookmark/use it to open a marimo notebook on GitHub

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

Copy link

vercel bot commented Jan 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 5:26am
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 5:26am

Copy link

vercel bot commented Jan 11, 2025

@Haleshot is attempting to deploy a commit to the marimo Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@akshayka akshayka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One note to address — the bookmarklet also works with .ipynb files. They get automatically converted to marimo notebooks before being opened in the playground.

@Haleshot
Copy link
Contributor Author

Thanks! One note to address — the bookmarklet also works with .ipynb files. They get automatically converted to marimo notebooks before being opened in the playground.

Have included .ipynb's and mentioned it in the note too.

akshayka
akshayka previously approved these changes Jan 11, 2025
Copy link
Contributor

@akshayka akshayka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the QoL improvement!

Copy link
Contributor

@akshayka akshayka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Haleshot actually one thing, marimo.app/URL actually works with non-github URLs too I believe. The URL just needs to end with .py or ipynb. If you could restore the original URL construction that would be great, thanks!

@Haleshot
Copy link
Contributor Author

Haleshot commented Jan 11, 2025

@Haleshot actually one thing, marimo.app/URL actually works with non-github URLs too I believe. The URL just needs to end with .py or ipynb. If you could restore the original URL construction that would be great, thanks!

Updated it accordingly (to the best of my knowledge). Hope it's fine now.

@akshayka akshayka merged commit ccf3a19 into marimo-team:main Jan 11, 2025
18 of 19 checks passed
Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.13-dev2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants