Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add vega-datasets package to framework examples #3405

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

RaulPL
Copy link
Contributor

@RaulPL RaulPL commented Jan 12, 2025

📝 Summary

When running the frameworks examples, the app fails to execute the dataframe.py because of vega-datasets missing dependency. This PR adds the vega-datasets package to each main.py script of the frameworks examples.

🔍 Description of Changes

Add the vega-datasets package to each main.py script of the frameworks examples

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

Copy link

vercel bot commented Jan 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2025 5:42pm

Copy link

vercel bot commented Jan 12, 2025

@RaulPL is attempting to deploy a commit to the marimo Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Jan 12, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@RaulPL
Copy link
Contributor Author

RaulPL commented Jan 12, 2025

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@mscolnick mscolnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@mscolnick mscolnick merged commit a4832cd into marimo-team:main Jan 12, 2025
10 of 11 checks passed
Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.13-dev3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants