[wip] fix: better chatbot input & bubble #3404
Open
+110
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Light2Dark is attempting to deploy a commit to the marimo Team on Vercel. A member of the Team first needs to authorize it. |
mscolnick
reviewed
Jan 12, 2025
| ref={inputRef} | ||
| <PromptInput | ||
| className="rounded-sm mr-2" | ||
| placeholder="Type your message here, / for prompts" |
There was a problem hiding this comment.
can we change the placeholder of prompts exist or not
| @@ -277,8 +283,17 @@ export const PromptInput = ({ | |||
| }), | |||
| ); | |||
|
|
|||
| // Trigger autocompletion for text that begins with @ or | |||
| // @ + additional symbols specified | |||
| const matchBeforeRegex = additionalCompletions | |||
There was a problem hiding this comment.
Can we do 2 separate mentions plugins? One for "@" data and one for "/" prompts; instead of appending the trigger, replace it.
|
I think the mention changes are good / worth keeping. I plan to add support for MCPs so we could eventually replace this with https://github.com/marimo-team/codemirror-mcp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fixes #3401 . Use codemirror as chatbot input,
/triggers autocomplete.🔍 Description of Changes
todo:
@is not working. need to investigate📋 Checklist
📜 Reviewers
@akshayka OR @mscolnick