Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure massa-xtask does not use gas_calibration when building the workspace #4812

Open
Leo-Besancon opened this issue Jan 14, 2025 · 0 comments · Fixed by #4818
Open

Ensure massa-xtask does not use gas_calibration when building the workspace #4812

Leo-Besancon opened this issue Jan 14, 2025 · 0 comments · Fixed by #4818
Assignees
@Leo-Besancon
Labels
bug Something isn't working p1

Comments

@Leo-Besancon
Copy link
Collaborator

On branch mainnet_2_3, because of #4761, a weird behaviour of Cargo (that expects features to only be additive) makes it that a cargo build in the root will enable the gas_calibration feature on massa-sc-runtime not only for massa-xtask, but also for massa-node and massa-client.
@Leo-Besancon Leo-Besancon linked a pull request Jan 14, 2025 that will close this issue
Disable default gas_calibration on massa-xtask #4811
Closed
8 tasks
@Leo-Besancon Leo-Besancon self-assigned this Jan 14, 2025
@Leo-Besancon Leo-Besancon linked a pull request Jan 15, 2025 that will close this issue
Fix features handling for massa-sc-runtime #4818
Merged
8 tasks
@Leo-Besancon Leo-Besancon added bug Something isn't working p1 labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Leo-Besancon Leo-Besancon

Labels
bug Something isn't working p1
Projects
None yet
Milestone
No milestone
1 participant
@Leo-Besancon