Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relying on data_returned #147

Open
eimrek opened this issue Apr 29, 2024 · 0 comments
Open

Relying on data_returned #147

eimrek opened this issue Apr 29, 2024 · 0 comments

Comments

@eimrek
Copy link
Member

eimrek commented Apr 29, 2024

The data_returned field in the /structures endpoint of the OPTIMADE specification is a 'SHOULD' (meaning, it's recommended, but not a requirement). For large databases (such as the li-ion-conductors one here: https://optimade.materialscloud.org/archive/vg-ya/v1/structures), we time out the count and return null there. The optimadeclient, however, seems to rely on this. This should be fixed, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant