Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CustomHTML tag textarea font to monospace #927

Open
ronan-hello opened this issue Nov 15, 2024 · 6 comments
Open

Update CustomHTML tag textarea font to monospace #927

ronan-hello opened this issue Nov 15, 2024 · 6 comments
Labels
Enhancement New feature or request triaged

Comments

@ronan-hello
Copy link

Hi,

Can you change the "CustomHTML" tag textarea font to "monospace" to get better code readability?

Thank you,
Ronan HELLO

@randy-innocraft randy-innocraft added Enhancement New feature or request triaged labels Nov 15, 2024
@randy-innocraft
Copy link

Hi @ronan-hello ,
Thank you for bringing this to our attention and for your valuable input.
Your suggestion seems like a valuable enhancement to our product.
We will forward this to our Product team for review and future consideration.
If you have any additional details or questions, please feel free to share them here.

@ronan-hello
Copy link
Author

Thank you for your interest in this issue!

Bests,
Ronan

@Stan-vw
Copy link

Stan-vw commented Dec 2, 2024

This is a nice suggestion, thank you Ronan.
I did a quick check internally whether we could roll this out for all places in Matomo where there is code (for example where the tracking code is shown), but I understand there's no global CSS that spans all of them.

With that in mind, I'm hesitant to make this change now because it'll introduce an improvement in a small area, but further inconsistency and technical debt across the wider platform. To implement it platform wide however, would be more work because we'd have to adjust a number of tests across the platform, QA that no places are forgotten, potentially realign a few things, etc. Unfortunately, I don't think that'll happen in the short term.

You're of course welcome to make a PR and we'll look at it. Otherwise, we'll keep it in the backlog and it'll be considered again in the future.

As always, keen to read any thoughts 👍

@ronan-hello
Copy link
Author

Hi Stan,

Thank you for your response,
Maybe using some utility classes will allow you to add this feature step by step without breaking your workflow?
No worries for this add-on, it will remain available to OnPremise users through Tag Manager Extended plugin

Best,
Ronan

@AltamashShaikh
Copy link
Contributor

@ronan-helloYou can add below css in TagManagerExtended plugin and that should do the work.

textarea#customHtml {
    font-family: monospace, monospace;
}

@ronan-hello
Copy link
Author

Hi,

I already added to the plugin before creating this issue, with some enhancement on several tags.

Thank you
Ronan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request triaged
Projects
None yet
Development

No branches or pull requests

4 participants