From 0aadfd9be6b586e5fdd21b589754f44773509e1e Mon Sep 17 00:00:00 2001
From: Nityanand Rai <107465508+Nityanand13@users.noreply.github.com>
Date: Mon, 14 Nov 2022 20:11:58 +0530
Subject: [PATCH] Improved code quality (#2)

* add  "/zoom setting usePMI" command

* update from 'master' branch

* save usePMI as user preference

* fix error handling in /zoom usePMI setting command

* update from upstream

* create meeting without PMI

* finish feature

* fix lint

* tidy go module

* update tests, optimize code

* tidy the go module

* [MI-1996]: Resolved the bug in use PMI feature of zoom plugin
1. Resolved the problem of  500 internal server error which we were getting on clicking create new meeting when our use PMI was set to ask
2. Added c.apiURL in URL
3. Added auto suggestion for use PMI

* [MI-1996]: Resolved merge conflicts

* [MI-1996]: Resolved the error of make: *** No rule to make target 'webapp/node_modules'. Stop

* [MI-1996]: Removed error of check-style

* [MI-1996]: Resolved the error faced in golangci-lint

* [MI-1996]: Review fixes done
1. Added constants at various places

* [MI-1996]:Review fixes done
1. Added EOF
2. Added Proper comments

* [MI-1996]:Resolved the panic that we were getting on running slash command of zoom plugin

* [MI-1996]: Work in Progress

* [MI-1996]:Added properly with and without PMI feature of zoom plugin

* [MI-1996]: Improved code quality

* [MI-1996]: Fixed CI errors

* [MI-1996]:Review fixes done
1.Improved code quality
2.Added various constants

* [MI-1996]: Review fixes done
1. Improved code quality
2. Changed few names

* [MI-1996]:Review fixes done
1. Improved code quality
2. Improved code readability
3. Resolved gramatical mistakes

* [MI-1996]: Review fixes done
1. Changed few names

* [MI-1996]: Review fixes done
1. Improved code readability
2. Removed indirect dependencies
3. Changed few names

* [MI-1996]: Review fixes done
1. Improved code quality
2. Returned json instead of text

* Fixed CI errors

* [MI-1996]:Review fixes done
1. Improved code quality

* [MI-1996]: Improved code quality

Co-authored-by: lantrungseo <lantrungseo@gmail.com>
---
 server/command.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/server/command.go b/server/command.go
index 3db6bbce..c1833a95 100644
--- a/server/command.go
+++ b/server/command.go
@@ -17,7 +17,7 @@ const (
 	helpText      = `* |/zoom start| - Start a zoom meeting`
 	oAuthHelpText = `* |/zoom connect| - Connect to Zoom
 * |/zoom disconnect| - Disconnect from Zoom`
-	settingHelpText        = `* |/zoom settings| - Configure settings options`
+	settingHelpText        = `* |/zoom settings| - Update your preferences`
 	alreadyConnectedText   = "Already connected"
 	zoomPreferenceCategory = "plugin:zoom"
 	zoomPMISettingName     = "use-pmi"
@@ -244,7 +244,7 @@ func (p *Plugin) runDisconnectCommand(user *model.User) (string, error) {
 
 // runHelpCommand runs command to display help text.
 func (p *Plugin) runHelpCommand() (string, error) {
-	text := starterText + strings.ReplaceAll(helpText+settingHelpText, "|", "`")
+	text := starterText + strings.ReplaceAll(helpText+"\n"+settingHelpText, "|", "`")
 	if p.configuration.EnableOAuth {
 		text += "\n" + strings.ReplaceAll(oAuthHelpText, "|", "`")
 	}