Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide whether to use PMI or not on instant meetings #154

Closed
larkox opened this issue Aug 11, 2020 · 3 comments · Fixed by #284
Closed

Decide whether to use PMI or not on instant meetings #154

larkox opened this issue Aug 11, 2020 · 3 comments · Fixed by #284
Labels
Difficulty/1:Easy Easy ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature

Comments

@larkox
Copy link
Contributor

larkox commented Aug 11, 2020

After #147 is merged, you will be able to create meetings with new IDs.

We would like to add a user setting set by slash commands (/zoom setting usePMI [true/false/ask]) to allow the user decide whether to use its PMI on instant meetings.

If the setting is set to ask, when it is going to create a meeting, they will receive an ephemeral message where they can choose to use the PMI or the new ID.
@larkox larkox added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Tech/Go Difficulty/1:Easy Easy ticket Type/Enhancement New feature or improvement of existing feature labels Aug 11, 2020
@aaronrothschild aaronrothschild mentioned this issue Oct 6, 2020
Open
@andrew-the-drawer
Copy link
Contributor

I want to try this issue. Thanks a lot!

@andrew-the-drawer andrew-the-drawer mentioned this issue Oct 30, 2020
Closed
@hanzei hanzei removed the Up For Grabs Ready for help from the community. Removed when someone volunteers label Oct 31, 2020
@andrew-the-drawer
Copy link
Contributor

@larkox I have a question: How can we send ephemeral post to user using postTypeZoom component? I tried but plugin.SendEphemeralPost(userID, post) doesn't render anything except Message. Or do I need to use other methods?

@larkox
Copy link
Contributor Author

larkox commented Nov 13, 2020

Answered here: #181 (comment)

Nityanand13 added a commit to Brightscout/mattermost-plugin-zoom that referenced this issue Nov 3, 2022
@Nityanand13
Merge branch 'mattermostGH-154-PMI-setting-command' of github.com:Bri…
b39d541 
…ghtscout/mattermost-plugin-zoom into MI-1996
Nityanand13 added a commit to Brightscout/mattermost-plugin-zoom that referenced this issue Nov 14, 2022
@Nityanand13
Merge branch 'mattermostGH-154-PMI-setting-command' of github.com:Bri…
48d4744 
…ghtscout/mattermost-plugin-zoom into MI-1996
Nityanand13 added a commit to Brightscout/mattermost-plugin-zoom that referenced this issue Nov 14, 2022
@Nityanand13
Merge branch 'mattermostGH-154-PMI-setting-command' of github.com:Bri…
f01ada0 
…ghtscout/mattermost-plugin-zoom into MI-1996
@Nityanand13 Nityanand13 mentioned this issue Nov 14, 2022
Merged
@hanzei hanzei linked a pull request Dec 2, 2022 that will close this issue
GH-154: Created the settings command to change the preferences for meeting creation #284
Merged
@mkdbns mkdbns moved this from Todo to Submitted in Brightscout Plugin Maintenance Apr 28, 2023
avas27JTG added a commit to Brightscout/mattermost-plugin-zoom that referenced this issue Oct 23, 2023
@avas27JTG
Merge branch 'master' of github.com:Brightscout/mattermost-plugin-zoo…
fbb4f88 
…m into mattermostGH-154-PMI-setting-command
avas27JTG added a commit to Brightscout/mattermost-plugin-zoom that referenced this issue Oct 25, 2023
@avas27JTG
Merge branch 'master' into mattermostGH-154-PMI-setting-command
589fccf
avas27JTG added a commit to Brightscout/mattermost-plugin-zoom that referenced this issue Oct 26, 2023
@avas27JTG
[mattermostGH-154]: Added logic to remove remove action buttons once …
953a0b0 
…user has selected an option for PMI setting.
avas27JTG added a commit to Brightscout/mattermost-plugin-zoom that referenced this issue Oct 26, 2023
@avas27JTG
[mattermostGH-154]: Fixed zoom video icon.
9816390
avas27JTG added a commit to Brightscout/mattermost-plugin-zoom that referenced this issue Oct 26, 2023
@avas27JTG
[mattermostGH-154]: Added original zoom video button styles.
dd77223
avas27JTG added a commit that referenced this issue Oct 27, 2023
@Nityanand13 @andrew-the-drawer @avas27JTG
GH-154: Created the settings command to change the preferences for me…
598725e 
…eting creation (#284)

* [MI-1996]: To solve the bugs in PMI feature of zoom plugin and to resolve merge conflicts (#1)

* add  "/zoom setting usePMI" command

* update from 'master' branch

* save usePMI as user preference

* fix error handling in /zoom usePMI setting command

* update from upstream

* create meeting without PMI

* finish feature

* fix lint

* tidy go module

* update tests, optimize code

* tidy the go module

* [MI-1996]: Resolved the bug in use PMI feature of zoom plugin
1. Resolved the problem of  500 internal server error which we were getting on clicking create new meeting when our use PMI was set to ask
2. Added c.apiURL in URL
3. Added auto suggestion for use PMI

* [MI-1996]: Resolved merge conflicts

* [MI-1996]: Resolved the error of make: *** No rule to make target 'webapp/node_modules'. Stop

* [MI-1996]: Removed error of check-style

* [MI-1996]: Resolved the error faced in golangci-lint

* [MI-1996]: Review fixes done
1. Added constants at various places

* [MI-1996]:Review fixes done
1. Added EOF
2. Added Proper comments

* [MI-1996]:Resolved the panic that we were getting on running slash command of zoom plugin

* [MI-1996]: Work in Progress

* [MI-1996]:Added properly with and without PMI feature of zoom plugin

* [MI-1996]: Improved code quality

* [MI-1996]: Fixed CI errors

* [MI-1996]:Review fixes done
1.Improved code quality
2.Added various constants

* [MI-1996]: Review fixes done
1. Improved code quality
2. Changed few names

* [MI-1996]:Review fixes done
1. Improved code quality
2. Improved code readability
3. Resolved gramatical mistakes

* [MI-1996]: Review fixes done
1. Changed few names

* [MI-1996]: Review fixes done
1. Improved code readability
2. Removed indirect dependencies
3. Changed few names

* [MI-1996]: Review fixes done
1. Improved code quality
2. Returned json instead of text

* Fixed CI errors

* [MI-1996]:Review fixes done
1. Improved code quality

Co-authored-by: lantrungseo <[email protected]>

* Improved code quality (#2)

* add  "/zoom setting usePMI" command

* update from 'master' branch

* save usePMI as user preference

* fix error handling in /zoom usePMI setting command

* update from upstream

* create meeting without PMI

* finish feature

* fix lint

* tidy go module

* update tests, optimize code

* tidy the go module

* [MI-1996]: Resolved the bug in use PMI feature of zoom plugin
1. Resolved the problem of  500 internal server error which we were getting on clicking create new meeting when our use PMI was set to ask
2. Added c.apiURL in URL
3. Added auto suggestion for use PMI

* [MI-1996]: Resolved merge conflicts

* [MI-1996]: Resolved the error of make: *** No rule to make target 'webapp/node_modules'. Stop

* [MI-1996]: Removed error of check-style

* [MI-1996]: Resolved the error faced in golangci-lint

* [MI-1996]: Review fixes done
1. Added constants at various places

* [MI-1996]:Review fixes done
1. Added EOF
2. Added Proper comments

* [MI-1996]:Resolved the panic that we were getting on running slash command of zoom plugin

* [MI-1996]: Work in Progress

* [MI-1996]:Added properly with and without PMI feature of zoom plugin

* [MI-1996]: Improved code quality

* [MI-1996]: Fixed CI errors

* [MI-1996]:Review fixes done
1.Improved code quality
2.Added various constants

* [MI-1996]: Review fixes done
1. Improved code quality
2. Changed few names

* [MI-1996]:Review fixes done
1. Improved code quality
2. Improved code readability
3. Resolved gramatical mistakes

* [MI-1996]: Review fixes done
1. Changed few names

* [MI-1996]: Review fixes done
1. Improved code readability
2. Removed indirect dependencies
3. Changed few names

* [MI-1996]: Review fixes done
1. Improved code quality
2. Returned json instead of text

* Fixed CI errors

* [MI-1996]:Review fixes done
1. Improved code quality

* [MI-1996]: Improved code quality

Co-authored-by: lantrungseo <[email protected]>

* Done the Review fixes of a PR #284 (#3)

* add  "/zoom setting usePMI" command

* update from 'master' branch

* save usePMI as user preference

* fix error handling in /zoom usePMI setting command

* update from upstream

* create meeting without PMI

* finish feature

* fix lint

* tidy go module

* update tests, optimize code

* tidy the go module

* [MI-1996]: Resolved the bug in use PMI feature of zoom plugin
1. Resolved the problem of  500 internal server error which we were getting on clicking create new meeting when our use PMI was set to ask
2. Added c.apiURL in URL
3. Added auto suggestion for use PMI

* [MI-1996]: Resolved merge conflicts

* [MI-1996]: Resolved the error of make: *** No rule to make target 'webapp/node_modules'. Stop

* [MI-1996]: Removed error of check-style

* [MI-1996]: Resolved the error faced in golangci-lint

* [MI-1996]: Review fixes done
1. Added constants at various places

* [MI-1996]:Review fixes done
1. Added EOF
2. Added Proper comments

* [MI-1996]:Resolved the panic that we were getting on running slash command of zoom plugin

* [MI-1996]: Work in Progress

* [MI-1996]:Added properly with and without PMI feature of zoom plugin

* [MI-1996]: Improved code quality

* [MI-1996]: Fixed CI errors

* [MI-1996]:Review fixes done
1.Improved code quality
2.Added various constants

* [MI-1996]: Review fixes done
1. Improved code quality
2. Changed few names

* [MI-1996]:Review fixes done
1. Improved code quality
2. Improved code readability
3. Resolved gramatical mistakes

* [MI-1996]: Review fixes done
1. Changed few names

* [MI-1996]: Review fixes done
1. Improved code readability
2. Removed indirect dependencies
3. Changed few names

* [MI-1996]: Review fixes done
1. Improved code quality
2. Returned json instead of text

* Fixed CI errors

* [MI-1996]:Review fixes done
1. Improved code quality

* [MI-1996]: Improved code quality

* [MI-1996]:Done the review fixes of a PR #284
1. Improved code quality
2. Changed the names of few constants

* [MI-1996]: Review fixes done
1. Changed few names

* [MI-1996]: Review fixes done
1. Modified error

* [MI-1996]: Review fixes done
1. Changed default topic to topic

* [MI-1996]: Review fixes done
1. Improved code quality

Co-authored-by: lantrungseo <[email protected]>

* Review fixes done
1.Improved code readability

* [MI-2571]: Done the review fixes of PR: #284 (#4)

* [MI-2571]: Review fixes done
1. Improved code quality and readability

* [MI-2571]: Review fixes done
1.Improved code quality

* [MI-2571]: Review fixes done
1. Changed status code

* [MI-2571]: Review fixes done
1. Improved code quality
2. Changed few names of variables and functions

* [MI-2571]: Review fixes done
1. Improved code quality

* [MI-3656]: Fixed test case.

* [GH-154]: Added logic to remove remove action buttons once user has selected an option for PMI setting.

* [GH-154]: Fixed zoom video icon.

* [GH-154]: Added original zoom video button styles.

---------

Co-authored-by: lantrungseo <[email protected]>
Co-authored-by: Abhishek Verma <[email protected]>
Co-authored-by: Abhishek Verma <[email protected]>
@github-project-automation github-project-automation bot moved this from Submitted / In Review to Done in Brightscout Plugin Maintenance Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty/1:Easy Easy ticket Hacktoberfest Help Wanted Community help wanted Tech/Go Type/Enhancement New feature or improvement of existing feature
Projects
Brightscout Plugin Maintenance
Status: Done
Milestone
No milestone
5 participants
@jespino @larkox @cpanato @hanzei @andrew-the-drawer