Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displ_BackLight(uint8_t cmd) doesnt initialize Backlight correctly when using PWM #5

Open
tiwag opened this issue Apr 24, 2024 · 0 comments

Comments

@tiwag
Copy link

tiwag commented Apr 24, 2024

First i want to thank you for your brilliant implementation of the ST7735 driver,
most performant driver i had a look at .... THANKS !!!

i found a small issue initializing PWM for backlight in the function
uint32_t Displ_BackLight(uint8_t cmd)

instead of setting the correct CCR value, it calls itself

case 'I': HAL_TIM_PWM_Start(&BKLIT_T, BKLIT_CHANNEL); Displ_BackLight(BKLIT_INIT_LEVEL); <<<<<<<<<<<<<< doesnt work break;

correction, tested and ok

case 'I': HAL_TIM_PWM_Start(&BKLIT_T, BKLIT_CHANNEL); BKLIT_TIMER->BKLIT_CCR=BKLIT_INIT_LEVEL; break;

brgds, tiwag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant