Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is possible to inline geckodriver? #5

Open
linux-china opened this issue Jul 27, 2024 · 1 comment
Open

Is possible to inline geckodriver? #5

linux-china opened this issue Jul 27, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@linux-china
Copy link

For beginners, it's still some hard to try. You should install geckodriver command line and FireFox. Firefox is ok for developers and geckodriver is unfamiliar for most developers. Could Scout add geckodriver as dependency and inline geckodriver into Scout.

Stacktrace without geckodriver, not friendly for developers. Is possible to give hint to ask developers to install geckodriver.

$ scout scripts/demo.sct
thread 'main' panicked at /Users/user1/.cargo/registry/src/index.crates.io-6f17d22bba15001f/scoutlang-0.6.0/src/main.rs:68:10:
error spinning up driver process: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Stacktrace without Firefox. Is possible to ask developers to install Firefox from https://www.mozilla.org/en-US/firefox/new/

❯ scout demo.sct
thread 'main' panicked at src/main.rs:90:10:
error starting browser: Failed(hyper::Error(Connect, ConnectError("tcp connect error", Os { code: 61, kind: ConnectionRefused, message: "Connection refused" })))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@maxmindlin maxmindlin added the enhancement New feature or request label Jul 27, 2024
@maxmindlin
Copy link
Owner

Hey @linux-china - yes I think including geckodriver and firefox in the install is a good idea and have always intended to do it, I just haven't decided on the best way to do so. I'm open to suggestions or PRs on this topic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants