From 3dbaef05c3e9ec8395ff11edeb6b4ed04e719409 Mon Sep 17 00:00:00 2001 From: Paige Gulley Date: Fri, 26 Jul 2024 17:27:52 -0400 Subject: [PATCH] comment to explain the top_domains aggregation in overview --- client.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/client.py b/client.py index 5f1e6c8..7e64d7e 100644 --- a/client.py +++ b/client.py @@ -280,6 +280,9 @@ def aggregator_query( # Only return the total and matches if explicitly requested if "overview" in options: + # We use a sum of the top_domains to supplement the total, as elasticsearch has a hard limit + # of 10,000 results per page in a source query, but aggregators can go around this. + # if QueryBuilder.Aggregators.TOP_DOMAINS not in aggs: raise HTTPException( status_code=500,