Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebRTC examples don't work on master #52

Open
mat-hek opened this issue Dec 9, 2024 · 1 comment · May be fixed by #57
Open

WebRTC examples don't work on master #52

mat-hek opened this issue Dec 9, 2024 · 1 comment · May be fixed by #57
Assignees
@FelonEkonom
Labels
bug Something isn't working

Comments

@mat-hek
Copy link
Member

mat-hek commented Dec 9, 2024

At least the first two examples in examples.livemd don't work when you take Boombox from GH. The browser either hangs in connecting state or switches to disconnected.
@mat-hek mat-hek added this to Smackore Dec 9, 2024
@mat-hek mat-hek moved this to Todo in Smackore Dec 9, 2024
@mat-hek mat-hek added the bug Something isn't working label Dec 9, 2024
@FelonEkonom FelonEkonom moved this from Todo to In Review in Smackore Jan 2, 2025
@FelonEkonom FelonEkonom moved this from In Review to In Progress in Smackore Jan 2, 2025
@FelonEkonom
Copy link
Member

FelonEkonom commented Jan 7, 2025 •
edited
Loading

Issues:

  • bug in signaling channel - awaits on Bump version to 0.23.1 membrane_webrtc_plugin#15
  • bug in codecs negotiation: Browser echo negotiates VP8 on one side of one connection and H264 on the second connection, while the negotiated codec should be the same
  • missing keyframe request in Browser echo example
  • Add test using headless Chrome
  • Allow connecting from both tabs for each side of the connection at the same time

@FelonEkonom FelonEkonom linked a pull request Jan 7, 2025 that will close this issue
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FelonEkonom FelonEkonom

Labels
bug Something isn't working
Projects
Smackore
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bugs in related to browser connecting via WebRTC membraneframework/boombox
2 participants
@mat-hek @FelonEkonom