New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more Rust like interfaces for Config #5

Open

ronniec95 opened this issue Dec 9, 2019 · 1 comment

ronniec95 commented Dec 9, 2019

Just some small changes

For gbdt::config::Config,

a ConfigBuilder (following the builder pattern) that has a build() method to create a Config() object is more Rust like.
The to_string() method is not necessary if you implement Display.
The config.set_loss function takes str rather than an enum.

Are you open to PRs?

Contributor

dingelish commented Dec 9, 2019

Thanks! I’d happy to merge PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment