Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List class is not namespaced #22

Open
joris opened this issue Oct 4, 2018 · 1 comment
Open

List class is not namespaced #22

joris opened this issue Oct 4, 2018 · 1 comment
Labels
enhancement
Milestone
v2

Comments

@joris
Copy link
Contributor

joris commented Oct 4, 2018

I happen to have a List class in my own application.
As this gem defines a List in the global/root namespace as well (in lib/messagebird/list.rb), installing the gem breaks my app.
@joris
Copy link
Contributor Author

joris commented Oct 4, 2018

Should be fixed with this PR

@epels epels added this to the v2 milestone Oct 18, 2018
@jalerson jalerson mentioned this issue Apr 3, 2022
Merged
marcelcorso pushed a commit that referenced this issue Apr 11, 2022
Merge pull request #23 from joris/master
75e564b 
Wrapped List class inside MessageBird namespace (Solves issue #22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v2
Development

No branches or pull requests
2 participants
@joris @epels