Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production builds get interrupted by PR builds #295

Open
strogonoff opened this issue Jan 8, 2025 · 3 comments
Open

Production builds get interrupted by PR builds #295

strogonoff opened this issue Jan 8, 2025 · 3 comments

Comments

@strogonoff
Copy link
Contributor

Screenshot 2025-01-07 at 21 25 21

Can we allow production builds to continue to completion?

@ronaldtse
Copy link
Contributor

@strogonoff there is this section in the build workflow definition:

concurrency:
  group: ${{ github.workflow }}-${{ github.head_ref || github.ref_name }}
  cancel-in-progress: true

You would want to define a good "group" and see if you need cancel-in-progress. Typically for build of pages we cancel in progress builds because it will be replaced immediately later by the subsequent build.

@strogonoff
Copy link
Contributor Author

I don’t know the details of this standard development process so I don’t know what’s the right solution. I just think we don’t need to deploy to GHP from branches/PRs, and main branch builds should be priority.

And also if we merge the caching PR then this would be less of an issue.

@strogonoff
Copy link
Contributor Author

strogonoff commented Jan 8, 2025

Caching PR: #290

(I think we should make sure cache is shared between branches for best efficiency.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants