Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement packet batching #326

Closed
rohiievych opened this issue Jul 14, 2022 · 1 comment
Closed

Implement packet batching #326

rohiievych opened this issue Jul 14, 2022 · 1 comment
Assignees
@kramarmm
Labels
metarhia-s'22 streams

Comments

@rohiievych
Copy link
Member

rohiievych commented Jul 14, 2022 •
edited
Loading

The task

Currently metacom streams do not optimize chunks provided by the data source. Websockets use frames for messages, thus if we have a lot of small messages it creates additional overhead with frame metadata. We can reduce it by grouping binary packets to optimal size like 1Mb, which will improve websocket performance.

How to implement

  1. Take control over chunks and concat them into single one with desired size.

Create a PR to branch streams
kramarmm added a commit to kramarmm/metacom that referenced this issue Jul 18, 2022
@kramarmm
accumulate chunks until min size (1Mb) is reached
baf2d22 
Closes: metarhia#326
@kramarmm kramarmm mentioned this issue Jul 18, 2022
Closed
1 task
@rohiievych
Copy link
Member Author

Closing in favor of extended version of this issue: #336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kramarmm kramarmm

Labels
metarhia-s'22 streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accumulate chunks until min size (1Mb) is reached kramarmm/metacom
3 participants
@tshemsedinov @rohiievych @kramarmm