-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement more LISP operators #5
Comments
Can I use list of operators and their declaration ( And do I need to extend the describe('Arithmetic Operations', () => {
it('Evaluate subtract operator', () => {
const program = '(- x y)';
const context = { x: 5, y: 2 };
const result = evaluate(program, context);
const expected = 5 - 2;
assert.strictEqual(result, expected, 'Subtract operator failed');
});
//... other arithmetic operators tests
}); |
@tshemsedinov Should comparison operators support sequences of more than two arguments? From Common Lisp the Language, 2nd Edition
|
@imbroyury Great question! I think it's relevant for the arithmetical operators too. Don't you want to share this issue? I've already started with arithmetic operators and can go logical or bitwise, and you can take comparison and something you want. And also thanks for the common lisp resource. It's really strange that I missed it. |
@tshemsedinov I've created a pull request with an implementation of arithmetic operators. But I'm not experienced in open source and because of it don't know how to attach this PR to this particular issue #11 |
@zpwebbear happy to implement comparison operators as soon as @tshemsedinov comments on supporting sequences and your commit is merged |
@tshemsedinov also to implement Logical Operators we need to implement |
@tshemsedinov I've added the boolean symbols implementation in the separate PR #12 Could you please take a look? For some reason I can't assign any reviewer on this PR. |
Additionly type field was added to all Expression classes Refs: metarhia#5
The text was updated successfully, but these errors were encountered: