Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce better reporters instead of tap-mocha-reporter #265

Open
lundibundi opened this issue Mar 16, 2022 · 0 comments
Open

Introduce better reporters instead of tap-mocha-reporter #265

lundibundi opened this issue Mar 16, 2022 · 0 comments

Comments

@lundibundi
Copy link
Member

The tap-mocha-reporter library is not supported and is already causing some issues like:

  • YAML library warning from set syntax
  • wrong diff-ing of Set/Map with nested objects and other complex structures

So we should add better reporters and phase out (or at least remove from 'default') tap-mocha-reporters.
lundibundi added a commit that referenced this issue Mar 16, 2022
@lundibundi
fix: remove yaml warnings
a66c9f8 
Due to the fact that newer versions of yaml library (1.7.0+)
produce warning when trying to print nested objects in `set`
and at the same time tap-mocha-reporter doesn't support yaml
output that fixes this warning (mapAsMap: true) we have to just
silence them like this.
This would still result in "empty" diff on some reporters but
at least we will not get warnings that clutter whole report.

Refs: #265
@KLarpen KLarpen mentioned this issue Dec 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lundibundi