Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All variables in variables.ini should be given a vert_type #1454

Open
lewisblake opened this issue Dec 11, 2024 · 5 comments
Open

All variables in variables.ini should be given a vert_type #1454

lewisblake opened this issue Dec 11, 2024 · 5 comments
Labels
enhancement ✨ New feature or request good first issue Good for newcomers low-hanging-fruit-🍎 bare blåbær
Milestone

Comments

@lewisblake
Copy link
Member

lewisblake commented Dec 11, 2024

Is your feature request related to a problem? Please describe.
The vert_type attribute of a species is a fundamental attribute needed when creating an experiment. However, pyaerocom has no native way of representing this metadata. It is assumed that this metadata is provided in a config though the obs_vert_type argument which is given to an instance of ObsEntry. If no observations are provided (i.e., I just want to plot model data), then this information is not available because ModelEntry has no such attribute (It has no variable information and therefore no place to put it). I propose that in variables.ini we provide each variable a default vert_type which can be used in cases where the attribute obs_vert_type is not available.

Describe the solution you would like to see
A clear and concise description of what you want to happen.

  • Would you be able to work on this solution yourself? Yes
  • How can the Pyaerocom development team assist you? Input

Additional context
Related to wanting to show just model data.

@lewisblake lewisblake added enhancement ✨ New feature or request good first issue Good for newcomers low-hanging-fruit-🍎 bare blåbær labels Dec 11, 2024
@lewisblake lewisblake added this to the m2025-01 milestone Dec 11, 2024
@jgriesfeller
Copy link
Member

Sounds reasonable to me. But keep it changeable.

@heikoklein
Copy link
Member

Please state what you need the vert_types for. Column-variables need to be strictly distinct in the definition since they have different units than in-situ, so this differentiation makes sense. Measurement in different model-layers will have the same units as Surface, so it does not make sense.

@lewisblake lewisblake modified the milestones: m2025-01, m2025-02 Jan 6, 2025
@Ovewh
Copy link
Collaborator

Ovewh commented Jan 8, 2025

What is the Surface and Column vert types supposed to mean for the model? Also whatever the definition of these is supposed to be it is not use consistently between different models. Thus pyaerocom might mess up units if for one model it is given vert_type Column, while another model have given the same variable vert_type Surface.

Also when just plotting model data, do we need a "native way", model data does generally have units included it the netcdf attributes?

@lewisblake
Copy link
Member Author

From pyaerocom 13.01.25:

The Surface is the lowest layer to the ground (lowest of a 3D field), whereas the Column is the integral (sum) of the entire vertical column. The vert_type is per variable, so if a model handled it in a different way, then one would need to specify that in their config. Jan is happy to discuss with you @Ovewh.

As a side note, I'm still not sure if this is worth going forward with at this point. Heiko raises well the main concern of when it doesn't make sense.

@lewisblake
Copy link
Member Author

Work around from AeroTools 14.01.25: Variables which are not Surface (and maybe Column) should be given a different variable name and have their vert_type specified in variables.ini

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request good first issue Good for newcomers low-hanging-fruit-🍎 bare blåbær
Projects
None yet
Development

No branches or pull requests

4 participants