Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation indexes should be unsigned #33

Open
bjv-capra opened this issue Jan 4, 2022 · 0 comments
Open

Translation indexes should be unsigned #33

bjv-capra opened this issue Jan 4, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@bjv-capra
Copy link
Collaborator

Currently, all indexes

  • HW_ID
  • TASK_ID
  • UPDATER_ID
  • KEY

are signed int16_t values, one shouldn't be indexing anything on a negative value (although could be possible). Thus, I'd suggest changing these indexes to be uint16_t instead.
@bjv-capra bjv-capra added enhancement New feature or request help wanted Extra attention is needed labels Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bjv-capra