From 5d2ee79eeeac7b582af12e6bfd0f96d873a3a12d Mon Sep 17 00:00:00 2001 From: Tom Laird-McConnell Date: Mon, 14 Nov 2016 19:36:56 -0800 Subject: [PATCH] remove old show/hide Credits hookup --- src/client/addressBar/addressBarMenu.tsx | 6 +----- src/client/reducers.ts | 18 ------------------ 2 files changed, 1 insertion(+), 23 deletions(-) diff --git a/src/client/addressBar/addressBarMenu.tsx b/src/client/addressBar/addressBarMenu.tsx index de6d66d03..f3971a2aa 100644 --- a/src/client/addressBar/addressBarMenu.tsx +++ b/src/client/addressBar/addressBarMenu.tsx @@ -118,11 +118,7 @@ export class AddressBarMenu extends React.Component<{}, {}> { }, { label: 'Credits', - // click: () => AddressBarActions.showCredits() - click: () => { - let path = 'https://github.com/Microsoft/BotFramework-Emulator/blob/master/ThirdPartyLicenses.txt'; - window.open(path); - } + click: () => window.open('https://github.com/Microsoft/BotFramework-Emulator/blob/master/ThirdPartyLicenses.txt') }, { type: 'separator' diff --git a/src/client/reducers.ts b/src/client/reducers.ts index c008c0e49..068821ec4 100644 --- a/src/client/reducers.ts +++ b/src/client/reducers.ts @@ -88,10 +88,6 @@ type AddressBarAction = { type: 'AddressBar_ShowAbout' } | { type: 'AddressBar_HideAbout' -} | { - type: 'AddressBar_ShowCredits' -} | { - type: 'AddressBar_HideCredits' } | { type: 'AddressBar_ShowAppSettings' } | { @@ -197,16 +193,6 @@ export class AddressBarActions { type: 'AddressBar_HideAbout' }) } - static showCredits() { - dispatch({ - type: 'AddressBar_ShowCredits' - }) - } - static hideCredits() { - dispatch({ - type: 'AddressBar_HideCredits' - }) - } static showAppSettings() { this.hideBotCreds(); this.hideSearchResults(); @@ -371,10 +357,6 @@ export const addressBarReducer: Reducer = ( return Object.assign({}, state, { showAbout: true }); case 'AddressBar_HideAbout': return Object.assign({}, state, { showAbout: false }); - case 'AddressBar_ShowCredits': - return Object.assign({}, state, { showCredits: true }); - case 'AddressBar_HideCredits': - return Object.assign({}, state, { showCredits: false }); case 'AddressBar_ShowAppSettings': return Object.assign({}, state, { showAppSettings: true }); case 'AddressBar_HideAppSettings':