Remove _createDataStoreWithProps
#22993
Assignees
Labels
Comments
tyler-cai-microsoft
added a commit
that referenced
this issue
Jan 8, 2025
[AB#856](https://dev.azure.com/fluidframework/235294da-091d-4c29-84fc-cdfc3d90890b/_workitems/edit/856) #22993 ### Description Removes APIs that have been deprecated. We have tried to move away from `_createDataStoreWithProps` as this causes collisions when creating live datastores. Solutions involved aliasing. The original issue with the removal was that there was no way to put in props. Added the `initialState` parameter to `PureDataObjectFactory.createInstanceWithDataStore` as pass in props. ### Remove APIs - `IContainerRuntimeBase._createDataStoreWithProps` - `ContainerRuntime._createDataStoreWithProps` ### Alternatives - `PureDataObjectFactory.createInstanceWithDataStore` allows props to be passed in via the `initialState` parameter. ### Merge Notes - Merge only after `main` is ready for 2.20 changes. --------- Co-authored-by: Tyler Butler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Removed APIs
IContainerRuntimeBase._createDataStoreWithPropsContainerRuntime._createDataStoreWithPropsContext
AB#856
These apis have been deprecated for over 1 year. We have been trying to remove this api for over 2 years: #11351
Alternatives
The recommended approach is to now use the
PureDataObjectFactory.createInstanceWithDataStoreto pass in properties and create your datastore.Compatibility Concerns
Any usages of
_createDatastoreWithPropsshould be removedExpected Timeline
Removal target:
2.20.0The text was updated successfully, but these errors were encountered: