Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyvisa sim instruments are not cleanup on close. #5356

Closed
jenshnielsen opened this issue Sep 11, 2023 · 1 comment · Fixed by #5341 or #5360
Closed

Pyvisa sim instruments are not cleanup on close. #5356

jenshnielsen opened this issue Sep 11, 2023 · 1 comment · Fixed by #5341 or #5360

Comments

@jenshnielsen
Copy link
Collaborator

This can be exposed by reordering tests for example with https://pypi.org/project/pytest-randomly/

It turns out that this is due to a bug in pyvisa-sim requireing the resource manager to also be shutdown. pyvisa/pyvisa-sim#82

We could perhaps extend close to also kill the resource manager if we are running on a simulated instrument.
@jenshnielsen jenshnielsen mentioned this issue Sep 12, 2023
Merged
@jenshnielsen jenshnielsen reopened this Sep 13, 2023
@jenshnielsen
Copy link
Collaborator Author

Reopened since the solution did not work and is reverted in #5363

A draft solution is in #5360

@jenshnielsen jenshnielsen mentioned this issue Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jenshnielsen