Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added m1 cli package #4949

Merged
merged 7 commits into from
Jan 8, 2025
Merged

Added m1 cli package #4949

merged 7 commits into from
Jan 8, 2025

Conversation

afourney
Copy link
Member

@afourney afourney commented Jan 8, 2025

Closes #4907

@afourney afourney added this to the 0.4.0 milestone Jan 8, 2025
Copilot
Copilot AI reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • python/packages/magentic-one-cli/LICENSE-CODE: Language not supported

python/packages/magentic-one-cli/pyproject.toml Outdated Show resolved Hide resolved
@afourney afourney marked this pull request as ready for review January 8, 2025 20:53
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.48%. Comparing base (a427b38) to head (48e0a2e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...xt/src/autogen_ext/models/openai/_openai_client.py 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #4949       +/-   ##
===========================================
+ Coverage   55.71%   68.48%   +12.77%     
===========================================
  Files          68      156       +88     
  Lines        5781    10060     +4279     
===========================================
+ Hits         3221     6890     +3669     
- Misses       2560     3170      +610
Flag Coverage Δ
unittests 68.48% <66.66%> (+12.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afourney afourney requested a review from ekzhu January 8, 2025 21:40
raimondasl
raimondasl approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@raimondasl raimondasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@afourney afourney merged commit 7131dc9 into main Jan 8, 2025
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@raimondasl raimondasl raimondasl approved these changes

@jackgerrits jackgerrits Awaiting requested review from jackgerrits

@gagb gagb Awaiting requested review from gagb

@ekzhu ekzhu Awaiting requested review from ekzhu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Add magentic-one PyPI package for convenient installation of m1 CLI tool and magentic one Python API.
3 participants
@afourney @raimondasl @jackgerrits