Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The use of the package browserify-sign could violate Microsoft crypto policy #4840

Open
Majd-Zayyad-MSFT opened this issue Dec 30, 2024 · 0 comments

Comments

@Majd-Zayyad-MSFT
Copy link

Majd-Zayyad-MSFT commented Dec 30, 2024

The library crypto-browserify which is a dependency in the newest version of botframework-connector uses browserify-sign which uses another package elliptic which, in turn uses hash.js. The use of the package hash.js violates Microsoft policy for the use approved crypto libraries.

We have received a security alert for having this module in our package-lock, and after investigating, it turns out that we get it from botframework-connector. We kindly ask that this module is either removed or that an investigation is opened to verify that no code flows into any of the functionality of hash.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant