Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(domain): workspace assignments should only care about managed resources #182

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(domain): workspace assignments should only care about managed resources #182

wants to merge 2 commits into from
+39 −15

Conversation

DariuszPorowski
Copy link
Member

@DariuszPorowski DariuszPorowski commented Jan 6, 2025 •
edited
Loading

📥 Pull Request

❓ What are you trying to address

  • Currently domain_workspace_assignments resource enforce assignments based only on TF configuration. It means if someone adds more resources manually on the Fabric side, the next run of TF will remove it. Expected behavior: Resource must only manage TF provided configuration.

This fix is related (not directly) to #174 and potentially to #183

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025 •
edited
Loading

Changelog Preview

v0.1.0-dev - January 08, 2025

✨ Added

  • #135 Definition support in the fabric_eventhouse Resource
  • #156 Definition support in the fabric_eventhouse Data-Sources

🪲 Fixed

  • #174 Provider produced inconsistent result after apply error appears when using fabric_domain_workspace_assignments multiple times due to enforce assignments based only on TF configuration and ignoring the real state on teh Fabric side.
    Resource must only manage TF provided configuration and ignore any configuration provided outside TF.

@DariuszPorowski DariuszPorowski linked an issue Jan 6, 2025 that may be closed by this pull request
[BUG] Provider produced inconsistent result after apply #174
Open
1 task
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025 •
edited
Loading

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 74% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 62% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 72% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 62% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 84% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/provider 86% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 70% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/domain 40% 0 ❌
github.com/microsoft/terraform-provider-fabric/internal/services/environment 87% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 92% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 82% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 86% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/spark 74% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 92% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 92% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 78% 0 ✔
Summary 73% (3828 / 5269) 0 ✔

Minimum allowed line rate is 40%

This was referenced Jan 8, 2025
Open
Open
@DariuszPorowski DariuszPorowski linked an issue Jan 8, 2025 that may be closed by this pull request
[BUG] Error during the creation of fabric_domain_workspace_assignments #183
Open
1 task
@DariuszPorowski DariuszPorowski force-pushed the feat/rs_domain_workspace_assignment branch from 503358d to 64001fb Compare January 8, 2025 19:56
@DariuszPorowski DariuszPorowski marked this pull request as ready for review January 8, 2025 19:56
@DariuszPorowski DariuszPorowski requested a review from a team as a code owner January 8, 2025 19:56
@DariuszPorowski DariuszPorowski added this to the 2025-01 milestone Jan 8, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 7.69231% with 24 lines in your changes missing coverage. Please review.

Project coverage is 76.49%. Comparing base (5578a67) to head (64001fb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...es/domain/resource_domain_workspace_assignments.go 5.26% 18 Missing ⚠️
...in/models_resource_domain_workspace_assignments.go 14.28% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
- Coverage   76.58%   76.49%   -0.10%     
==========================================
  Files         148      148              
  Lines       12631    12643      +12     
==========================================
- Hits         9674     9671       -3     
- Misses       2952     2967      +15     
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DariuszPorowski DariuszPorowski

Labels
None yet
Projects
None yet
Milestone
2025-01
2 participants
@DariuszPorowski @codecov-commenter