Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to move the find dialog to somewhere else #238337

Open
syockit opened this issue Jan 21, 2025 · 2 comments · May be fixed by #238345
Open

Option to move the find dialog to somewhere else #238337

syockit opened this issue Jan 21, 2025 · 2 comments · May be fixed by #238345
Assignees
@hediet

Comments

@syockit
Copy link

syockit commented Jan 21, 2025

When editing files with no proper LSP plugin support, no symbols appear in the outline panel. But the syntax parser can still work and identify fold positions appropriately. Hierarchy of the fold you are currently viewing are also displayed at the top of the document view, and this greatly aids navigation.

Unfortunately, when pressing Ctrl-F to bring up the Find dialog, the dialog obscures the fold hiearchy indicator. Therefore, I'd like to be able to move the Find dialog elsewhere, for example, the bottom of the document view.
@albertosantini
Copy link

Not exactly your issue, but very similar
#233782

crestyeagle added a commit to crestyeagle/vscode that referenced this issue Jan 21, 2025
@crestyeagle
Add option to move the Find dialog to the bottom of the document view
7c68e7b 
Fixes microsoft#238337

Add option to move the Find dialog to the bottom of the document view.

* Update `OverlayWidgetPositionPreference` enum in `src/vs/editor/browser/editorBrowser.ts` to include a new value `BOTTOM_CENTER`.
* Modify `FindWidget` class in `src/vs/editor/contrib/find/browser/findWidget.ts` to support positioning the Find dialog at the bottom based on the new configuration option.
* Adjust `_reveal` and `_hide` methods in `src/vs/editor/contrib/find/browser/findWidget.ts` to handle the new bottom position.
* Add CSS styles in `src/vs/editor/contrib/find/browser/findWidget.css` to handle the new bottom position of the Find dialog.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/vscode/issues/238337?shareId=XXXX-XXXX-XXXX-XXXX).
@crestyeagle crestyeagle linked a pull request Jan 21, 2025 that will close this issue
Open
@jrieken jrieken assigned hediet and unassigned jrieken Jan 21, 2025
@syockit
Copy link
Author

syockit commented Jan 22, 2025

Thanks @albertosantini, it is indeed the same issue, at least from what I gather MuayTy was trying to convey after clarifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hediet hediet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to move the Find dialog to the bottom of the document view crestyeagle/vscode
4 participants
@albertosantini @jrieken @hediet @syockit