Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: Prometheus.WindowsExporter version 0.30.0 #213700

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

New package: Prometheus.WindowsExporter version 0.30.0 #213700

wants to merge 3 commits into from
+86 −0

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Jan 18, 2025 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Manual validation

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error Policy-Test-2.7 labels Jan 18, 2025
@Dragon1573 @jkroepke
Apply suggestions from code review
8e988f1 
- Change the "Default Install Location" property
- Correction of "Copyright" property
- Remove "non-sense" value from "Tags" property

Co-authored-by: Jan-Otto Kröpke <[email protected]>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Policy-Test-2.7 Validation-Executable-Error New-Package labels Jan 19, 2025
@Dragon1573 @jkroepke
Apply suggestions from code review
7f19682 
- Rename portable binary, as instructed in microsoft#213642

Co-authored-by: Jan-Otto Kröpke <[email protected]>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error Policy-Test-2.7 labels Jan 19, 2025
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Program Files\windows_exporter\windows_exporter.exe returned exit code: 1

(Automated response - build 949.)

@stephengillie
Copy link
Collaborator

stephengillie commented Jan 21, 2025 •
edited
Loading

I'm pretty sure that the Policy-Test-2.7 label is accidental, from removing the space between "Windows" and "Exporter". A well-known answers site has the same issue.

@stephengillie
Copy link
Collaborator

Manual Validation ended with:

10:43:10 AM: 2025-01-22 10:42:55.088 [FAIL] C:__w\1\s\external\pkg\src\AppInstallerCommonCore\Manifest\YamlParser.cpp(537)\WindowsPackageManager.dll!00007FFCAE04D69A: (caller: 00007FFCADDA83B4) Exception(2) tid(1670) 8A150004 Msg:[[YAML:Scanner] while scanning for the next token [line 46; col 1] found character that cannot start any token [line 46; col 1]]

(Automated response - build 953.)

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jan 22, 2025
@jkroepke
Copy link

As someone, who would like to understand the eco system. How I should interpret this? From my point of view, the YAML file looks fine.

@Dragon1573
Copy link
Contributor Author

✅ Manual validate again.

ℹ️ Note: I have trouble connect to the origin download URL, so I manually download the file separately and save it on my local "cache" server.

--> Installing WinGet
--> Disabling safety warning when running installers
Tip: you can type 'Update-EnvironmentVariables' to update your environment variables, such as after installing a new software.

--> Configuring Winget
Enabled admin setting 'LocalManifestFiles'.
Enabled admin setting 'LocalArchiveMalwareScanOverride'.

--> Installing the Manifest 0.30.0

Found windows_exporter [Prometheus.WindowsExporter] Version 0.30.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading http://alist.dragon1573.local/d/windows_exporter-0.30.0-amd64.msi
  ██████████████████████████████  11.4 MB / 11.4 MB
Successfully verified installer hash
Starting package install...
Successfully installed

--> Refreshing environment variables

--> Comparing ARP Entries

DisplayName      DisplayVersion Publisher            ProductCode                            Scope
-----------      -------------- ---------            -----------                            -----
windows_exporter 0.30.0         prometheus-community {A7B06148-F35F-485E-A77E-5787916498D8} Machine

PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> & 'C:\Program Files\windows_exporter\windows_exporter.exe'
time=2025-01-23T16:21:19.959Z level=WARN source=cs.go:75 msg="The cs collector is deprecated and will be removed in a future release. Logical processors has been moved to cpu_info collector. Physical memory has been moved to memory collector. Hostname has been moved to os collector."
time=2025-01-23T16:21:19.959Z level=WARN source=os.go:108 msg="The os collect holds a number of deprecated metrics and will be removed mid 2025. See https://github.com/prometheus-community/windows_exporter/pull/1596 for more information." collector=os
time=2025-01-23T16:21:20.159Z level=INFO source=main.go:311 msg="Running as C9AAF6AC-D13D-4\\WDAGUtilityAccount"
time=2025-01-23T16:21:20.159Z level=INFO source=main.go:228 msg="Enabled collectors: cpu, cs, memory, logical_disk, physical_disk, net, os, service, system"
time=2025-01-23T16:21:20.160Z level=INFO source=main.go:246 msg="starting windows_exporter in 214.6886ms" version=0.30.0 branch=HEAD revision=86e6d12518d2fa7f8f2f632634ade3aaa34fba22 goversion=go1.23.4 builddate=20250114-22:51:51 maxprocs=28
time=2025-01-23T16:21:20.160Z level=ERROR source=main.go:283 msg="Failed to start windows_exporter" err="listen tcp :9182: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted."

It seems the server will be automatically launched after installation.

PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> Invoke-RestMethod -Uri http://localhost:9182/health

status
------
ok


PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> Invoke-RestMethod -Uri http://localhost:9182/metrics
# HELP go_build_info Build information about the main Go module.
# TYPE go_build_info gauge
go_build_info{checksum="",path="github.com/prometheus-community/windows_exporter",version="(devel)"} 1
# HELP go_gc_duration_seconds A summary of the wall-time pause (stop-the-world) duration in garbage collection cycles.
# TYPE go_gc_duration_seconds summary
go_gc_duration_seconds{quantile="0"} 0
go_gc_duration_seconds{quantile="0.25"} 0
go_gc_duration_seconds{quantile="0.5"} 0
go_gc_duration_seconds{quantile="0.75"} 5.95e-05
go_gc_duration_seconds{quantile="1"} 5.95e-05
go_gc_duration_seconds_sum 5.95e-05
go_gc_duration_seconds_count 4
...... (Other stuff ignored)

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 23, 2025
@jkroepke
Copy link

It seems the server will be automatically launched after installation.

the msi installs a service which starts the server. this is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkroepke jkroepke jkroepke left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. New-Package Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request]: windows_exporter
4 participants
@Dragon1573 @wingetbot @stephengillie @jkroepke