Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: DuckStudio.GitHubView.Nightly version 2025.01.22.12907017964 #215274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Jan 22, 2025

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Manual validation

--> Installing WinGet
--> Disabling safety warning when running installers
Tip: you can type 'Update-EnvironmentVariables' to update your environment variables, such as after installing a new software.

--> Configuring Winget
Enabled admin setting 'LocalManifestFiles'.
Enabled admin setting 'LocalArchiveMalwareScanOverride'.

--> Installing the Manifest 2025.01.22.12907017964

Found GitHubView [DuckStudio.GitHubView.Nightly] Version 2025.01.22.12907017964
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
This package requires the following dependencies:
  - Packages
      Microsoft.DotNet.Runtime.8
(1/1) Found Microsoft .NET Runtime 8.0 [Microsoft.DotNet.Runtime.8] Version 8.0.12
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://builds.dotnet.microsoft.com/dotnet/Runtime/8.0.12/dotnet-runtime-8.0.12-win-x64.exe
  ██████████████████████████████  27.2 MB / 27.2 MB
Successfully verified installer hash
Starting package install...
Successfully installed

Downloading https://github.com/DuckDuckStudio/GitHubView/releases/download/2025.01.22.12907017964/GitHubView-2025.01.22.12907017964-windows-latest-x64-Setup.exe
  ██████████████████████████████  2.04 MB / 2.04 MB
Successfully verified installer hash
Starting package install...
Successfully installed

--> Refreshing environment variables

--> Comparing ARP Entries

DisplayName                           DisplayVersion         Publisher             ProductCode                            Scope
-----------                           --------------         ---------             -----------                            -----
GitHubView 版本 2025.01.22.12907017964  2025.01.22.12907017964 鸭鸭「カモ」                GitHubView_is1                         Machine
Microsoft .NET Runtime - 8.0.12 (x64) 8.0.12.34403           Microsoft Corporation {ba2e9943-e30e-49df-89e8-7db7905c6cf0} Machine

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@Dragon1573
Copy link
Contributor Author

Important

Should be reviewed by @DuckDuckStudio 🙏🏼


PackageIdentifier: DuckStudio.GitHubView.Nightly
PackageVersion: 2025.01.22.12907017964
InstallerLocale: en-US
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
InstallerLocale: en-US
InstallerLocale: zh-CN

image
我不确定应该填哪个语言,但之前的清单中我填 zh-CN
image
(在 iss 文件中)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英文语言的is1叫Default,但我没有明确指定哪种语言为默认。

Comment on lines +21 to +25
ProductCode: GitHubView_is1
ReleaseDate: 2025-01-22
AppsAndFeaturesEntries:
- ProductCode: GitHubView_is1
ElevationRequirement: elevatesSelf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ProductCode: GitHubView_is1
ReleaseDate: 2025-01-22
AppsAndFeaturesEntries:
- ProductCode: GitHubView_is1
ElevationRequirement: elevatesSelf
ReleaseDate: 2025-01-22

我在 iss 文件中没有指定 ProductCode。
当程序以用户范围安装时,不需要提升权限。

Comment on lines +13 to +14
License: GPL-3.0
LicenseUrl: https://github.com/DuckDuckStudio/GitHubView/blob/HEAD/LICENSE.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
License: GPL-3.0
LicenseUrl: https://github.com/DuckDuckStudio/GitHubView/blob/HEAD/LICENSE.txt
License: GNU General Public License v3.0
LicenseUrl: https://github.com/DuckDuckStudio/GitHubView/blob/master/LICENSE.txt

与英文清单保持一致

Comment on lines +33 to +37
ReleaseNotes: |-
## What's Changed
- Updated Development Documentation by @DuckDuckStudio in #12

**Full Changelog**: https://github.com/DuckDuckStudio/GitHubView/compare/2025.01.14.12764289055...2025.01.15.12782147412
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ReleaseNotes: |-
## What's Changed
- Updated Development Documentation by @DuckDuckStudio in #12
**Full Changelog**: https://github.com/DuckDuckStudio/GitHubView/compare/2025.01.14.12764289055...2025.01.15.12782147412
ReleaseNotes: |-
What's Changed
- refactor(build): Refactoring the build release workflow by @DuckDuckStudio in #18
Full Changelog: https://github.com/DuckDuckStudio/GitHubView/compare/2025.01.19.12849721517...2025.01.22.12907017964
ReleaseNotesUrl: https://github.com/DuckDuckStudio/GitHubView/releases/tag/2025.01.22.12907017964

错误的发行说明

Copy link
Contributor

Hello @Dragon1573,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 22, 2025
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes-Requested Changes Requested Needs-Author-Feedback This needs a response from the author. Validation-Installation-Error Error installing application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Update Request]: DuckStudio.GitHubView.Nightly version 2025.01.22.12907017964
3 participants