Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbols <> in title name (and file name as result) prevent application from downloading. #1633

Open
6 tasks done
Kelniimir opened this issue Jan 9, 2025 · 0 comments
Open
6 tasks done
Labels
Bug Something isn't working

Comments

@Kelniimir
Copy link

Kelniimir commented Jan 9, 2025

Steps to reproduce

  1. Add manga which have corresponding symbols in title, to library. Example https://senkognito.com/manga/kabeyaku-nado-fuyou-to-tsuihou-sareta-s-kyuu-boukensha-dorei-kaihou-skill-wo-kushi-shite-shijou-saikyou-no-kunizukuri
  2. Enable automatic download of new chapters (settings->downloads->download new chapters turned on)
  3. On any new update to title (new chapters added to "download queue"), current chapter isn't downloaded, as well as ANY other chapter from ANY other site/plugin, which are currently in queue or added after.
  4. After issue is triggered, application usually raises notification
    "Downloader
    Invalid location: /storage/emulated/0/ Backup/Mihon/downloads"
    P.S. Path mentioned is configured download location. There is no access issues during this moment - already downloaded chapters are visible and accessible.
  5. After chapter with <> symbols in filename is deleted from "download queue", all other title chapters are downloaded without issues.
  6. Attempt to READ chapter without downloading causes no issues, pages open as expected.
  7. Attempt to download any chapter of such title manually triggers issue as well - chapter isn't downloading, notification pops up, nothing downloads untill chapter is deleted from download queue.
  8. Tested and reproducing on builds from 0.16.x to 0.17.1 (current up-to-date), extension Senkognito.com 1.4.3

Expected behavior

Chapters download as expected.
Any unsupported symbols in filename converted to _ or anything else upon attempting to download.

Actual behavior

Automatic download or manual download of chapter from title which includes special symbol causes no chapters downloaded of current or any other title, untill "Download queue" is cleared manually from chapters with special symbols.

Crash logs

Application isn't exactly crashing.
Logs with "verbose" enabled, while attempting to reproduce the issue on 09.01.2025 11:47 provided.
mihon_crash_logs (1).txt

Mihon version

0.17.1

Android version

Android 14, OneUI 6.1

Device

Samsung Galaxy S23U (SM-S918B/DS)

Other details

Issue reproduced on different extensions as well, and seems to be related to application, regardless of extension in use.
Example with Senkognito is just last scenario.
Common workaround was to search same title on other site(other extension), which used other symbols in title.
Issue was triggering on multiple extensions through, and was first seen on 0.15.x. Couldn't test it back then as I was not certain of what triggered it back then.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.17.1.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@Kelniimir Kelniimir added the Bug Something isn't working label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant