Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Flash on page change" flashing of black screen is not enough to combat ghosting #585

Closed
6 tasks done
d4rky-pl opened this issue Mar 27, 2024 · 6 comments · Fixed by #625
Closed
6 tasks done
Labels
Bug Something isn't working

Comments

@d4rky-pl
Copy link

Steps to reproduce

On certain cheap e-ink readers (Likebook Mars in my case) just flashing the black screen is not enough to clear the ghosting effect. The screen flashes but ghosting remains.

FILE.2024-03-27.12.02.41.mp4

Expected behavior

The screen should likely do a full cycle of flashing white, then black to clear the ghosting correctly. The way Kindle solves it is by flashing a negative of the image but implementing this might be more complex. Additionally, a 1.5s delay is not necessary and does not actually help with the ghosting, it's mostly just annoying.

Actual behavior

The screen flashes to pitch black with some ghosting remaining, then after (too long) 1.5s delay switches to the next page while the previous page contents remain in the form of ghosting

IMAGE 2024-03-27 12:06:22

Crash logs

No response

Mihon version

0.16.4

Android version

Android 8

Device

Likebook Mars (t80d)

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.16.4.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@d4rky-pl d4rky-pl added the Bug Something isn't working label Mar 27, 2024
@d4rky-pl d4rky-pl changed the title The "Flash on page change" flashing only black is not enough The "Flash on page change" flashing of black screen is not enough to combat ghosting Mar 27, 2024
@AntsyLich
Copy link
Member

So white -> black -> next page and no delay in-between?

@BrutuZ
Copy link

BrutuZ commented Mar 27, 2024

There is a reverse colors filter in the reader already, so the Kindle technique might not be that complex to implement

@vodkapmp
Copy link
Contributor

If any changes are to be implemented here, could there be added an option to flash white-black every x page?

Personally the minor amount of ghosting that happens per page change isn't that much of an annoyance for me, as the display on my Onyx Boox Max Lumi is quite good for ghosting.
The flashing every page is much more annoying, but a refresh is needed every now and then to clear it up when it accumulates over 4-5 pages.

@d4rky-pl
Copy link
Author

@AntsyLich some delay may be required because eink displays have very slow refresh rate so they're skipping frames like crazy. Definitely not 1.5s though, I don't think that helps with anything

@sirlag
Copy link
Contributor

sirlag commented Mar 28, 2024

I know we are trying in general to cut down on settings, but given the differences in behavior across e-ink displays and the relative level of niche, I think making this configurable but hidden might make the most sense

@koshisan
Copy link

I am not sure how feasible this is, since it might be even more niche, but the boox/onyx devices do provide an API for eink display related stuff.

https://github.com/onyx-intl/OnyxAndroidDemo?tab=readme-ov-file

Not only can you trigger a refresh as intended, you could even use different screen modes for different things. For example I like to read my manga in HD mode, but that of course is way too slow to browse through the library...

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants