Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo and case sensible #28

Open
ncou opened this issue Nov 26, 2017 · 0 comments
Open

typo and case sensible #28

ncou opened this issue Nov 26, 2017 · 0 comments

Comments

@ncou
Copy link

ncou commented Nov 26, 2017

Hi,

Very nice lib, i looked at the code and it seems to me there is :

  1. a typo error in a comment for the regex explanation line 154 :

[^\s()<>]+ # Run of non-space, non-()<>
the "-" character is no more in the regex, so it should be removed from the comment.

  1. line 167 there is a check to verify if there is a need to add an "http" value in the link. I think you should add an "~i" value to avoid the case sensitive problem. For example if someone add a text "hTTp://www.xxx.xxx" the http will be added because your regex is case sensitive.

Keepup the good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant