Numpy 2 compatability #67
Comments
joeloskarsson
added
bug
|
One error message we get with numpy 2 is "Alias np.float_ has been removed. Use np.float64 instead." (from @sadamov) |
## Describe your changes Nerual-lam is at the moment not completely compatible with the new release of numpy 2. This PR changes the numpy version in requirements.txt to < 2.0.0. ## Issue Link #67 ## Type of change - [x] 🐛 Bug fix (non-breaking change that fixes an issue) - [ ] ✨ New feature (non-breaking change that adds functionality) - [ ] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 📖 Documentation (Addition or improvements to documentation) ## Checklist before requesting a review - [x] My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use `pull` with `--rebase` option if possible). - [x] I have performed a self-review of my code - [x] I have given the PR a name that clearly describes the change, written in imperative form ([context](https://www.gitkraken.com/learn/git/best-practices/git-commit-message#using-imperative-verb-form)). - [x] I have requested a reviewer and an assignee (assignee is responsible for merging) ## Checklist for reviewers Each PR comes with its own improvements and flaws. The reviewer should check the following: - [x] the code is readable - [x] the code is well tested - [x] the code is documented (including return types and parameters) - [x] the code is easy to maintain ## Author checklist after completed review - [x] I have added a line to the CHANGELOG describing this change, in a section reflecting type of change (add section where missing): - *added*: when you have added new functionality - *changed*: when default behaviour of the code has been changed - *fixes*: when your contribution fixes a bug ## Checklist for assignee - [x] PR is up to date with the base branch - [x] the tests pass - [x] author has added an entry to the changelog (and designated the change as *added*, *changed* or *fixed*) - Once the PR is ready to be merged, squash commits and merge the PR.
|
@sadamov Do you remember any more information about where you ran into |
|
I have run all pre-processing scripts and the model training with the latest env from #32. Tested both on CPU/GPU to be sure, no issues. So this must mean that I was previously working with a dirty environment. Sometimes I managed to install numpy<2.0.0 with mamba and numpy>2.0.0 with pip on top. Probably some libraries in my env were still built against numpy=1.2.6 as a result. I apologies for wasting our time and suggest to close this issue. I will update my comment in #37 and reference this issue. |
|
Ok, great! I still think it was good to look into this and make sure that everything works with 2.0. For completion:
|
Nerual-lam is at the moment not completely compatible with the new release of numpy 2. At the moment the requirements specification includes numpy 2, so that is what will be installed when installing neural-lam.
While the upgrade to numpy 2 compatability is likely not huge, it is also not urgent. It is still good to first prevent this issue by changing the dependency specifier, and then we can put it on the roadmap to upgrade.
Things TODO:
The text was updated successfully, but these errors were encountered: