Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default configuration should capture errors #167

Open
sebffischer opened this issue Oct 21, 2024 · 2 comments
Open

Default configuration should capture errors #167

sebffischer opened this issue Oct 21, 2024 · 2 comments

Comments

@sebffischer
Copy link
Member

During a run with mlr3mbo with the default config we got:

INFO  [04:56:35.792] [bbotk]           429.392             <list[1]> ce827262-3214-4d9d-8be7-febba967c238
INFO  [04:56:35.915] [mlr3] Calling train method of fallback 'regr.ranger' on task 'surrogate_task' with 16 observations {learner: <LearnerRegrRanger/LearnerRegr/Learner/R6>}
Error in self$assert(xs, sanitize = TRUE) : 
  Assertion on 'xs' failed: epochs: May not be NA.
Calls: <Anonymous> ... resolve.list -> signalConditionsASAP -> signalConditions
In addition: There were 16 warnings (use warnings() to see them)
Execution halted

It would be nice if the default configuration for the surrogate model / acq-function optimizer would handle such failures.

@sumny
Copy link
Member

sumny commented Oct 26, 2024

Thanks for the report!
Is there any code snippet to reproduce it and develop against?
I assume these NA's in xs are domain values (and not codomain values because having NA in objective values would be impossible due to bbotk anyways)?
Is it a search space with dependencies? If yes, weird that the default surrogate does not handle this correctly but I will check for the fallback also.
If not, how can NA's in domain values happen?

Would be good to get some more input on how xs values happened to be NA here.

@sumny
Copy link
Member

sumny commented Nov 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants