-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Improve API of set_config #13052
Comments
I'm on board with the motivation for this change, it's not a quick-and-easy API for a task that should be quick-and-easy. But, having both old and new APIs in one function feels inelegant. Did you consider making Another thought: if in the current API the type hint for |
No, an
I don't think it solves the problems as well. My hope is to design an interface that is as clean/pythonic from the user end as possible. In this sense |
I just wanted to enable CUDA on my machine, and had to do
mne.get_config
to get the config keys to figure out what to set, which was a bit annoying. That is becauseset_config
has the api:So you have to know the key we use in the config file, which is really more of an implementation detail (though it does allow use via env vars, too, which is nice), i.e., I had to do:
What would have been a lot nicer would have been:
So I have the following API improvement proposal:
Thoughts?
@mscheltienne somewhere in the back of my mind I think you brought up something similar recently but after a search I couldn't find anything.
The text was updated successfully, but these errors were encountered: