Improve API design for String::concat

[illusory0x0]

if we concat Array[String], we have to xxx.iter().to_array(), I consider use Iter[String] uniformly handle all sequence.

and if Iter[String] is non termination, concat also is non termination, User should use Iter::take, before concat

let alphabet = [
  "A", "B", "C", "D", "E", "F", "G", "H", "I", "J", "K", "L", "M", "N", "O", "P",
  "Q", "R", "S", "T", "U", "V", "W", "X", "Y", "Z",
]

test {
  for i in 0..<27 {
    let s = String::concat(alphabet[0:i].iter().to_array())
    println(s)
  }
}

String::concat

Origin

String::concat(Array[String], separator~ : String = ..) -> String

New

String::concat(Iter[String], separator~ : String = ..) -> String

Array::flatten

Origin

pub fn Array::flatten[T](self : Array[Array[T]]) -> Array[T]

New

pub fn Array::flatten[T](self : Iter[Array[T]]) -> Array[T]

[gmlewis]

I REALLY dislike String::concat and sorely miss alphabet.join(", ").

[gmlewis]

This proposal makes the syntax even uglier in my opinion.

[illusory0x0]

I REALLY dislike String::concat and sorely miss alphabet.join(", ").

here is a possible API design

Iter::join(self : Iter[String], separator~ : String = ..) -> String

[Lampese]

I REALLY dislike and sorely miss .String::concat``alphabet.join(", ")

here is a possible API design

Iter::join(self : Iter[String], separator~ : String = ..) -> String

Are you seeking this?

• add Iter[String]::join #1301

[illusory0x0]

• add Iter[String]::join #1301

String::concat might need to be deprecated, otherwise, we need add concat_arrayview, concat_deque.....,

we shouldn't do the same thing in different way