Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replication changes sample order #725

Open
CodeCreator opened this issue Jul 15, 2024 · 3 comments
Open

Replication changes sample order #725

CodeCreator opened this issue Jul 15, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@CodeCreator
Copy link

Environment

  • mosaicml-streaming==0.7.5

To reproduce

Steps to reproduce the behavior:

  1. Use StreamingDataset in distributed training with the same seed and set replication either to None or an integer > 1
  2. Print out samples across all devices and ignore duplicated samples

Expected behavior

The overall order of the samples should be the same, but using replication seems to lead to a different random shuffling of the data

@CodeCreator CodeCreator added the bug Something isn't working label Jul 15, 2024
@snarayan21
Copy link
Collaborator

Hey! We don't currently guarantee deterministic sample order if replication changes, but I see how that would be useful. Will take note of this request. thanks!

@snarayan21
Copy link
Collaborator

@CodeCreator do you see this even when going from replication 2 -> replication 4, for example?

@CodeCreator
Copy link
Author

@snarayan21 yeah I'm also seeing changes to the sample order when changing the replication factor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants