Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test additions/adjustments from syncstorage-rs #120

Open
pjenvey opened this issue Jun 14, 2019 · 1 comment
Open

test additions/adjustments from syncstorage-rs #120

pjenvey opened this issue Jun 14, 2019 · 1 comment
Assignees
@pjenvey
Labels
🔃 Durable Sync spanner

Comments

@pjenvey
Copy link
Member

pjenvey commented Jun 14, 2019 •
edited
Loading

I'm tracking a few changes in the feat/spanner-tests-todo branch. It's mostly just adding a new test.

We may also need to adjust the strictness of test_timestamp_numbers_are_decimals. syncstorage-rs sometimes produces only 1 decimal point vs 2 (and I doubt the client cares but we should double check before changing this test).

FAIL: test_timestamp_numbers_are_decimals (syncstorage.tests.functional.support.LiveTestCases)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "syncstorage/tests/functional/test_storage.py", line 899, in test_timestamp_numbers_are_decimals
    self.assertEqual(len(str(ts).split(".")[-1]), 2)
AssertionError: 1 != 2
@pjenvey pjenvey self-assigned this Jun 14, 2019
@pjenvey
Copy link
Member Author

pjenvey commented Jul 11, 2020

Another item here: fxa_uid/kid + hashed_fxa_uid are not always treated similarly alongside the legacy user_id

pjenvey added a commit that referenced this issue Jul 11, 2020
@pjenvey
fix: ensure fxa_uid/kid/etc. are handled alongside user_id
824d400 
for spanner compatibility

Closes #120
pjenvey added a commit that referenced this issue Jul 11, 2020
@pjenvey
fix: ensure fxa_uid/kid/etc. are handled alongside user_id
409890e 
for spanner compatibility

Issue #120
@pjenvey pjenvey mentioned this issue Jul 11, 2020
Merged
pjenvey added a commit that referenced this issue Jul 13, 2020
@pjenvey
fix: ensure fxa_uid/kid/etc. are handled alongside user_id
4d6b391 
for spanner compatibility

+ fix the spanner backend lacking the new required is_migrating method

Issue #120
pjenvey added a commit that referenced this issue Jul 13, 2020
@pjenvey
fix: ensure fxa_uid/kid/etc. are handled alongside user_id
cd7d0e8 
for spanner compatibility

- fix the spanner backend lacking the new required is_migrating method
- bump rsa version per CVE-2020-13757

Issue #120
pjenvey added a commit that referenced this issue Jul 13, 2020
@pjenvey
fix: ensure fxa_uid/kid/etc. are handled alongside user_id
1da451a 
for spanner compatibility

- fix the spanner backend lacking the new required is_migrating method
- bump rsa version per CVE-2020-13757

Issue #120
pjenvey added a commit that referenced this issue Feb 6, 2023
@pjenvey
fix: ensure fxa_uid/kid/etc. are handled alongside user_id (#149)
4b0aaaa 
for spanner compatibility

- fix the spanner backend lacking the new required is_migrating method
- bump rsa version per CVE-2020-13757

Issue #120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
🔃 Durable Sync spanner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pjenvey